Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-events] Tap: change order of events #16694

Merged
merged 1 commit into from
Sep 9, 2019
Merged

[react-events] Tap: change order of events #16694

merged 1 commit into from
Sep 9, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Sep 7, 2019

Before:

start -> change -> update -> end (cancel) -> change

Now:

start -> change -> update -> change -> end (cancel)

@necolas
[react-events] Tap: change order of events
6170b7a 
Before:

start -> change -> update -> end (cancel) -> change

Now:

start -> change -> update -> change -> end (cancel)
@necolas necolas requested a review from trueadm September 7, 2019 00:37
@sizebot
Copy link

sizebot commented Sep 7, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 6170b7a

@necolas necolas merged commit 031eba7 into facebook:master Sep 9, 2019
@necolas necolas deleted the react-events/tap-event-order branch December 20, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@necolas @sizebot @trueadm @facebook-github-bot