-
Notifications
You must be signed in to change notification settings - Fork 47.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-events] Support screen reader virtual clicks #16584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 0da7bd0...7a8b04f react-events
Generated by 🚫 dangerJS |
necolas
reviewed
Aug 27, 2019
necolas
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address issues around using screen reader tooling (VoiceOver, NVDA, JAWS) with the
Press
event responder. We previously relied on "press" events firing when coming from a valid pointer/mouse/touch sequence of events. We also supported "Enter" and "Space" keyboard events. However, we did not take into account that screen reader tooling can also fire virtualclick
events to specific DOM nodes.Screen reader virtual click events have a pattern that makes them somewhat easy to detect. They seem to also have
0
as thenativeEvent.detail
, rather than1
and they also never provide screen co-ordinates (they are all always0
).Testing URL: https://m9zxnyvpj9.csb.app/