[react-events] Press responder simplification #16517
Conversation
| const onPressMove = props.onPressMove; | ||
|
|
||
| if (isFunction(onPressMove)) { | ||
| dispatchEvent( |
There was a problem hiding this comment.
Won't this mean that we fire pressmove even if our pointer might be outside the target?
| 'onPressChange', | ||
| 'onPressStart', | ||
| 'onPressChange', | ||
| 'onPressMove', |
There was a problem hiding this comment.
This relates to my comment above, surely if you move out, then end should fire?
There was a problem hiding this comment.
We can do that for events that aren't capturing the target. For now this is fine and consistent across pointers
This is a big change internally right? Are the plans to move the pointer moving behaviour to a |
|
This is just how web buttons work anyway. I don't think anyone is depending on how press move works. And there's no other option for touch events without measuring the hit rect every move which is not good for perf |
* Remove 'pressRetentionOffset' so we don't have to perform layout measurements during moves. * Maintain the pressed state while a pointer is down and moving, even if it moves outside the target. * Determine whether to call 'onPress' based on whether the pointer was released over the target. This aligns more closely with how the web natively deals with pointers and simplifies the responder. We only need to call getBoundingClientRect for touch pointers. Further revisions could be made to avoid target capturing for touch pointers with PointerEvents, which would leave the gBCR call only for the fallback TouchEvents.
227da9e to
7779b31
Compare
|
I'm going to abandon this and create a new responder – |
NOTE: this stacks on top of #16479 which I'll merge once we've internally synced what is currently in master. Preview-review should only look at the second commit in this PR "Press responder simplification".
This aligns more closely with how the web natively deals with pointers and simplifies the responder.
We only need to call getBoundingClientRect for touch pointers. Further revisions could be made to
avoid target capturing for touch pointers with PointerEvents, which would leave the gBCR call only
for the fallback TouchEvents.
Demo: https://codesandbox.io/s/latest-responder-build-rz96j30rp