Warn when Using String Refs #16217
Merged
Warn when Using String Refs #16217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 05dce75...fb04bc8 react-art
react-dom
react-test-renderer
react-reconciler
react-native-renderer
Generated by 🚫 dangerJS |
acdlite
reviewed
Jul 26, 2019
| false, | ||
| 'Component "%s" contains the string ref "%s". Support for string refs ' + | ||
| 'will be removed in a future major release. We recommend using ' + | ||
| 'createRef() instead.' + |
There was a problem hiding this comment.
Maybe mention useRef instead? Or at least also.
There was a problem hiding this comment.
Yeah it’s a common mistake to put createRef into a function component
acdlite
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the process to deprecate string refs (as per a larger proposal outlined here), expand string ref warning to fire for everyone who uses string refs (not just people on strict mode) to notify them of planned deprecation changes.