allow nested act()s from different renderers
#15816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
|
[outdated] |
threepointone
commented
Jun 4, 2019
acdlite
reviewed
Jun 11, 2019
| */ | ||
|
|
||
| const ReactCurrentActingRendererSigil = { | ||
| current: (null: null | (() => boolean)), | ||
| current: ([]: Array<{}>), |
There was a problem hiding this comment.
This is conceptually a Set, not an Array, so (assuming this is the approach we go with) let's make it an Set.
There was a problem hiding this comment.
I started this with a Set, until I realized it's not one. It's a stack. Consider when leaving an act() scope, if it was a Set, how could I know if the sigil has to be removed from the set?
976e5b3 to
3274578
Compare
act()s from different renderersact()s from different renderers
|
Open question - At what point should flushPassiveEffects be called? On exiting the last act of any type? Or for a given type? |
3274578 to
ee3d60e
Compare
sometimes apps can be made wtih multiple renderers. a specific usecase is react-art embedded inside react-dom. in these cases, we want to be able to wrap an update with acts corrsponding to both the renderers. In this PR, we change ReactCurrentActingRendererSigil to hold a stack of sigils (instead of just the current active one), pushing and popping onto it as required. This commit also fixes the dom fixtures tests, which were broken? ugh.
ee3d60e to
d17c220
Compare
|
abandoning this for #16039 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes apps can be tested with multiple renderers at once. Examples -
This PR is for the other 2 usecases. It replaces the sigil reference with a stack that holds all sigils as act scopes open/close, and compares against the stack for when to show the missing act() warning.
Open question - At what point should flushPassiveEffects be called? On exiting the last act of any type? Or for a given type?