Parallelizes the build script across multiple processes #15716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c9a37a to
9495d5d
Compare
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
|
Error code extraction is another blocker to parallelizing the build script. Don't feel like dealing with that now. I'll pick this task up some other time, not super crucial. |
65251b8 to
572c847
Compare
`bundle-sizes.json` contains the combined size information for every build. This makes it easier to store and process, but it prevents us from parallelizing the build script, because each process would need to write to the same file. So I've updated the Rollup script to output individual files per build. A downstream CI job consolidates them into a single file. I have not parallelized the Rollup script yet. I'll do that next.
Uses CircleCI's `parallelism` config option to spin up multiple build processes.
442c887 to
84e7c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15757 and #15758
Parallelizes the build script across multiple processes.
(Our CircleCI plan supports up to 300 parallel processes (!!!) per job, but there's no point making the build job faster than the test job, so I capped it at 20.)
To do this, I needed to change how we generate the bundle size JSON file. I changed the build script to generate a separate size file per build. A downstream CI job consolidates them into a single
bundle-sizes.jsonthat contains the combined size information for every build.