Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt to git tag a canary release #14376

Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Dec 2, 2018

After publishing a canary release:
screen shot 2018-12-02 at 11 34 11 am

After publishing a stable release:
screen shot 2018-12-02 at 11 34 27 am

(Note that I didn't actually publish either release above, just ran the script with a --dry flag.)

@threepointone
Copy link
Contributor

Canary releases have to be recorded in the changelog? And a release? Thought we’d do neither for canaries.

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 3, 2018

Canary releases have to be recorded in the changelog? And a release? Thought we’d do neither for canaries.

Good point. I guess I could suppress those messages too.

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 3, 2018

Okay, now when you publish a canary release the script just says:

A canary release has been pulbished!

The PR is mostly whitespace changes now, so the w=1 flag helps.

@bvaughn bvaughn force-pushed the release-scripts-git-tag-suggestion branch from c1d2046 to 1ea0f04 Compare December 3, 2018 16:21
@bvaughn bvaughn merged commit e382b0b into facebook:master Dec 3, 2018
@bvaughn bvaughn deleted the release-scripts-git-tag-suggestion branch December 3, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants