-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don’t add onclick listener to React root #13778
Merged
philipp-spiess
merged 6 commits into
facebook:master
from
philipp-spiess:ios-tap-highlight
Oct 9, 2018
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
45578e6
Don’t add onclick listener to React root
philipp-spiess f78da30
Make Flow happy by giving it more context
philipp-spiess 965b17c
It’s time to go to bed
philipp-spiess f0c2702
Check for null and undefined explicitly
philipp-spiess 4cf7175
We don't use destructuring
philipp-spiess ea25fe7
Cleanup DOMContainer usage and test assertions
philipp-spiess File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -360,7 +360,7 @@ export function appendChildToContainer( | |
// event exists. So we wouldn't see it and dispatch it. | ||
// This is why we ensure that containers have inline onclick defined. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we modify the comments together? |
||
// https://github.com/facebook/react/issues/11918 | ||
if (parentNode.onclick === null) { | ||
if (!container._reactRootContainer && parentNode.onclick === null) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Compare to null and undefined explicitly, plz |
||
// TODO: This cast may not be sound for SVG, MathML or custom elements. | ||
trapClickOnNonInteractiveElement(((parentNode: any): HTMLElement)); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just do
expect(typeof ...).toBe('function')
. Not that it matters.