Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Appveyor Badge #11698

Closed

Conversation

raphamorim
Copy link
Contributor

@raphamorim raphamorim commented Nov 29, 2017

Reference: #11605

Hi @gaearon, we still need to configure AppVeyor for facebook/react 🤓
I think in something like: https://ci.appveyor.com/project/facebook/react

@gaearon
Copy link
Collaborator

gaearon commented Nov 29, 2017

Kicked off the build, let's see if it works

@raphamorim
Copy link
Contributor Author

raphamorim commented Nov 29, 2017

Ok -crossed fingers-

@gaearon
Copy link
Collaborator

gaearon commented Nov 29, 2017

This fails:

screen shot 2017-11-29 at 01 54 23

Wanna look into making a fix? My guess is you can't just run yarn, have to add .cmd on Windows.

@raphamorim
Copy link
Contributor Author

Ok, I'll work on it.

@gaearon
Copy link
Collaborator

gaearon commented Nov 29, 2017

I fixed AppVeyor. I don't think we'll want a badge though. It's already getting very crowded.
We can still see AV status in the commit list so that should help catch regressions.
Thanks though!

@gaearon gaearon closed this Nov 29, 2017
@raphamorim raphamorim deleted the feature/add-appveyor-badge branch November 29, 2017 16:41
@raphamorim
Copy link
Contributor Author

Make sense @gaearon,
Sorry for delay and thanks 👍

@gaearon
Copy link
Collaborator

gaearon commented Nov 29, 2017

If you're interested, #11703

@raphamorim
Copy link
Contributor Author

raphamorim commented Nov 29, 2017

Nice, I'll see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants