Don't reset error codes on CI build #11655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah that works |
HeroProtagonist
pushed a commit
to HeroProtagonist/react
that referenced
this pull request
Nov 26, 2017
* Don't reset error codes on CI build * Add an explanation
raphamorim
pushed a commit
to raphamorim/react
that referenced
this pull request
Nov 27, 2017
* Don't reset error codes on CI build * Add an explanation
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Don't reset error codes on CI build * Add an explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was added in #8486 but if I'm not mistaken it causes issues after my changes in #11633.
Specifically, prod tests on bundles now run after build and actually depend on the up-to-date error code file being available. Otherwise any newly added invariants can't be "decoded", as they're not in the committed error code file.
I noticed this in #11652. Will see if the same fix there works. If it does, I'll merge this.