Fix production crash #11286
Merged
Fix production crash #11286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
approved these changes
Oct 19, 2017
| @@ -211,6 +211,28 @@ describe('ReactDOMProduction', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| // Regression test verifying that trying to access (missing) component stack doesn't crash. | |||
| it('should throw on children for void elements', () => { | |||
| const errorCode = 137; | |||
There was a problem hiding this comment.
You could put the entire error string into this var since it's duplicated below?
There was a problem hiding this comment.
Yeah, I guess.. Just copy paste from above tests. I don't really care. I'll have to get back to this and find another way to test it when I enable production testing of bundles.
There was a problem hiding this comment.
Sure, no big deal. Just seemed pretty arbitrary the way it was currently setup.
There was a problem hiding this comment.
I agree. I just don't want to spend time here because I'll delete those tests anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an embarrassing production crash I introduced in #11284. I misunderstood what this
fbjsfunction does.Verified this fixes it by trying the rebuilt bundle on FB.com in production mode.
Also by newly added regression test (which fails on master).