Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for <option selected="..."> #839

Closed
vjeux opened this issue Jan 8, 2014 · 2 comments
Closed

Warning for <option selected="..."> #839

vjeux opened this issue Jan 8, 2014 · 2 comments

Comments

@vjeux
Copy link
Contributor

vjeux commented Jan 8, 2014

Using <option selected="..."> is the standard way to set a value on a <select> component. Yet, React uses another convention: http://facebook.github.io/react/docs/forms.html#why-select-value

We should add a warning when the value is being set on the <option> and tell the developer to put value on the <select> in DEV.

Example: http://jsfiddle.net/vjeux/LT6Bw/

@sophiebits
Copy link
Collaborator

selected, you mean.

@vjeux
Copy link
Contributor Author

vjeux commented Jan 8, 2014

There's already a warning in fact ... Closing this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants