Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closure Compiler (Advanced Mode) externs #824

Closed
jhiswin opened this issue Jan 6, 2014 · 2 comments
Closed

Closure Compiler (Advanced Mode) externs #824

jhiswin opened this issue Jan 6, 2014 · 2 comments
Assignees
@zpao
Labels
Component: Build Infrastructure

Comments

@jhiswin
Copy link
Contributor

jhiswin commented Jan 6, 2014

este has already integrated into React into his Closure-centric framework. Here's the externs for React that steida has already created:
https://github.com/steida/este-library/blob/master/externs/react.js
It was made for 0.5.0, so it is missing some exports.

It might be good to add a mentions in the docs.

It could also be possible to make a script to automatically generate externs for React.
@zpao
Copy link
Member

zpao commented Jan 6, 2014

It should be relatively easy to autogenerate that. Want to take a stab at it and put the script in /scripts?

@ghost ghost assigned zpao Jan 8, 2014
@jochenberger jochenberger mentioned this issue Oct 11, 2016
Closed
@gaearon
Copy link
Collaborator

gaearon commented Oct 23, 2016

Closing as GCC advanced mode isn't really supported by React at this point.
It might have been supported if we set up any tests around this, but we didn't, and it regressed over time.

@gaearon gaearon closed this as completed Oct 23, 2016
josephsavona pushed a commit that referenced this issue May 15, 2024
@gsathya
[playground] Display only new HIR
e2cfbeb 
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with 
[ReviewStack](https://reviewstack.dev/facebook/react-forget/pull/824). * #825 * 
__->__ #824 

[playground] Display only new HIR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpao zpao

Labels
Component: Build Infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zpao @jhiswin @gaearon