Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools Bug]: Devtool extension build failing in windows and ubuntu #27193

Closed
Biki-das opened this issue Aug 5, 2023 · 10 comments
Closed

[DevTools Bug]: Devtool extension build failing in windows and ubuntu #27193

Biki-das opened this issue Aug 5, 2023 · 10 comments
Assignees

Comments

@Biki-das
Copy link
Contributor

Biki-das commented Aug 5, 2023

Website or app

N/A

Repro steps

Devtools extension is not building in ubuntu and windows

Below is the extension build failing in ubuntu even though it says chrome extension has built
bikid476@BIKISDESKTOP_ ~_react-1_packages_react-devtools-extensions 8_5_2023 1_40_08 PM

Below is the extension failing in windows
bikid476@BIKISDESKTOP_ ~_react-1_packages_react-devtools-extensions 8_5_2023 1_51_08 PM

It just fails with some artifact error!

@hoxyq 😅 My mac has gone dead and i am looking to tinker with devtools and have some ideas in plan to implement so we can fix this out and hopefully i can continue to work on devtools

How often does this bug happen?

Every time

DevTools package (automated)

No response

DevTools version (automated)

No response

Error message (automated)

No response

Error call stack (automated)

No response

Error component stack (automated)

No response

GitHub query string (automated)

No response

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

@Biki-das: We're sorry you've seen this error. ❤️

It looks like you forgot to specify a valid URL. (This means that we will not be able to reproduce the problem you're reporting.)

Please help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code example that reproduces the problem. (Screenshots or videos can also be helpful if they help provide context on how to repro the bug.)

Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

Issues without repros are automatically closed but we will re-open if you update with repro info.

@hoxyq
Copy link
Contributor

hoxyq commented Aug 7, 2023

Hey @Biki-das, thanks for reporting this!

I believe the problem with Windows related to not having build files ready, try running yarn build-for-devtools before building extensions.

Are you interested in investigating what's going wrong for Linux?

@Biki-das
Copy link
Contributor Author

Biki-das commented Aug 7, 2023

Reference

@hoxyq even running build-for-devtools it fails actually in windows

@hoxyq
Copy link
Contributor

hoxyq commented Aug 7, 2023

Reference

@hoxyq even running build-for-devtools it fails actually in windows

Not good. Are you interested in fixing this, maybe?

@Biki-das
Copy link
Contributor Author

Biki-das commented Aug 7, 2023

Reference

@hoxyq even running build-for-devtools it fails actually in windows

Not good. Are you interested in fixing this, maybe?

Yup let me investigate what's breaking and what can i interpret from it and get back to you!

@hoxyq
Copy link
Contributor

hoxyq commented Sep 5, 2023

Reference

@hoxyq even running build-for-devtools it fails actually in windows

Not good. Are you interested in fixing this, maybe?

Yup let me investigate what's breaking and what can i interpret from it and get back to you!

Any updates on this?

@PrathamLalwani
Copy link
Contributor

I can look into this if you want @hoxyq , I am not a beginner programmer but this will be my first contribution. Would you recommend this as a first bug?

@hoxyq
Copy link
Contributor

hoxyq commented Nov 10, 2023

I can look into this if you want @hoxyq , I am not a beginner programmer but this will be my first contribution. Would you recommend this as a first bug?

Sure, please also take into account that this bug is probably related to our build scripts and not React / React DevTools itself.

@Biki-das is this still reproducible? Can you please share the steps to reproduce this?

@Biki-das
Copy link
Contributor Author

Biki-das commented Nov 10, 2023

yeah sure
it is specific to windows OS though, just try to build the devtools from this guide

https://github.com/facebook/react/blob/main/packages/react-devtools/README.md

@hoxyq
Copy link
Contributor

hoxyq commented Nov 16, 2023

Fixed by #27692.

@hoxyq hoxyq closed this as completed Nov 16, 2023
hoxyq pushed a commit that referenced this issue Nov 16, 2023
## Summary

I had to change the commands to be windows specific so that it doesn't
cause any crashes

## How did you test this change?

I successfully built the different types of devtools extenstions on my
personal computer. In future may need to add a github action with
windows config to test these errors

 #27193
EdisonVan pushed a commit to EdisonVan/react that referenced this issue Apr 15, 2024
## Summary

I had to change the commands to be windows specific so that it doesn't
cause any crashes

## How did you test this change?

I successfully built the different types of devtools extenstions on my
personal computer. In future may need to add a github action with
windows config to test these errors

 facebook#27193
bigfootjon pushed a commit that referenced this issue Apr 18, 2024
## Summary

I had to change the commands to be windows specific so that it doesn't
cause any crashes

## How did you test this change?

I successfully built the different types of devtools extenstions on my
personal computer. In future may need to add a github action with
windows config to test these errors

 #27193

DiffTrain build for commit 2c338b1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants