Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn linc shouldn't fail because of file-has-not-changed warning #11615

Closed
gaearon opened this issue Nov 21, 2017 · 1 comment
Closed

yarn linc shouldn't fail because of file-has-not-changed warning #11615

gaearon opened this issue Nov 21, 2017 · 1 comment
Labels
Component: Build Infrastructure Difficulty: starter good first issue (taken)

Comments

@gaearon
Copy link
Collaborator

gaearon commented Nov 21, 2017

Just saw this after modifying ESLint config and running yarn linc:

/Users/gaearon/p/react/.eslintrc.js
  0:0  warning  File ignored by default.  Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override

✖ 1 problem (0 errors, 1 warning)

Lint failed for changed files.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
react)

We should not treat this particular warning as an error.
@HeroProtagonist
Copy link
Contributor

Hey! I would be interested in taking a stab at this one

@HeroProtagonist HeroProtagonist mentioned this issue Nov 23, 2017
Merged
gaearon pushed a commit that referenced this issue Nov 28, 2017
@HeroProtagonist @gaearon
Do not fail yarn linc for ignored file warning (#11615) (#11641)
7788bcd 
* Add rule to ignore default handling of not linting hidden files

* Undo changes

* Add function to validate warnings

* Use validateWarnings when reporting linc command

* Restore files

* Contain code to line file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Build Infrastructure Difficulty: starter good first issue (taken)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @HeroProtagonist