Validate portal container early

facebook · Sep 11, 2017 · f265e63 · f265e63
1 parent f74981b
commit f265e63
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/renderers/dom/fiber/ReactDOMFiberEntry.js b/src/renderers/dom/fiber/ReactDOMFiberEntry.js
@@ -747,6 +747,10 @@ var ReactDOMFiber = {
     container: DOMContainer,
     key: ?string = null,
   ) {
+    invariant(
+      isValidContainer(container),
+      'Target container is not a DOM element.',
+    );
     // TODO: pass ReactDOM portal implementation as third argument
     return ReactPortal.createPortal(children, container, null, key);
   },

diff --git a/src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js b/src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js
@@ -909,6 +909,18 @@ describe('ReactDOMFiber', () => {
       ]);
     });
 
+    fit('should throw on bad createPortal argument', () => {
+      expect(() => {
+        ReactDOM.unstable_createPortal(<div>portal</div>, null);
+      }).toThrow('Target container is not a DOM element.');
+      expect(() => {
+        ReactDOM.unstable_createPortal(
+          <div>portal</div>,
+          document.createTextNode('hi'),
+        );
+      }).toThrow('Target container is not a DOM element.');
+    });
+
     it('should warn for non-functional event listeners', () => {
       spyOn(console, 'error');
       class Example extends React.Component {