Skip to content

Commit

Permalink
Update on "[compiler] Fix merging of queues states in InferReferenceE…
Browse files Browse the repository at this point in the history
…ffects"


Fixes a bug found by mofeiZ in #29878. When we merge queued states, if the new state does not introduce changes relative to the queued state we should use the queued state, not the new state.

[ghstack-poisoned]
  • Loading branch information
josephsavona committed Jun 12, 2024
1 parent ac6ed0f commit c15c155
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function Foo(cond) {
x = [];
} else {
}
// Here, x = phi(x$null, x$[]) does not receive the correct ValueKind
// Here, x = phi(x$null, x$[]) should receive a ValueKind of Mutable
arrayPush(x, 2);

return x;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function Foo(cond) {
x = [];
} else {
}
// Here, x = phi(x$null, x$[]) does not receive the correct ValueKind
// Here, x = phi(x$null, x$[]) should receive a ValueKind of Mutable
arrayPush(x, 2);

return x;
Expand Down

0 comments on commit c15c155

Please sign in to comment.