Skip to content

Commit

Permalink
[Fiber] Don't call performance.now() twice in a row (#30936)
Browse files Browse the repository at this point in the history
DiffTrain build for [a5a7f10](a5a7f10)
  • Loading branch information
sebmarkbage committed Sep 10, 2024
1 parent bf9385a commit b8a98ad
Show file tree
Hide file tree
Showing 34 changed files with 98 additions and 98 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
66cf2cfc8a8c4b09d2b783fd7302ae6b24150935
a5a7f1063e6f190c64c779b2aa54d28fb7b92cfb
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
66cf2cfc8a8c4b09d2b783fd7302ae6b24150935
a5a7f1063e6f190c64c779b2aa54d28fb7b92cfb
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -2001,7 +2001,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.0.0-www-classic-66cf2cfc-20240910";
exports.version = "19.0.0-www-classic-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1981,7 +1981,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.0.0-www-modern-66cf2cfc-20240910";
exports.version = "19.0.0-www-modern-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-66cf2cfc-20240910";
exports.version = "19.0.0-www-classic-a5a7f106-20240910";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-66cf2cfc-20240910";
exports.version = "19.0.0-www-modern-a5a7f106-20240910";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-66cf2cfc-20240910";
exports.version = "19.0.0-www-classic-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-66cf2cfc-20240910";
exports.version = "19.0.0-www-modern-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -5417,7 +5417,7 @@ __DEV__ &&
}
function startProfilerTimer(fiber) {
profilerStartTime = now();
0 > fiber.actualStartTime && (fiber.actualStartTime = now());
0 > fiber.actualStartTime && (fiber.actualStartTime = profilerStartTime);
}
function stopProfilerTimerIfRunningAndRecordDelta(fiber, overrideBaseTime) {
if (0 <= profilerStartTime) {
Expand Down Expand Up @@ -16967,11 +16967,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-classic-66cf2cfc-20240910",
version: "19.0.0-www-classic-a5a7f106-20240910",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-classic-a5a7f106-20240910"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -17005,7 +17005,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-classic-66cf2cfc-20240910";
exports.version = "19.0.0-www-classic-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -5293,7 +5293,7 @@ __DEV__ &&
}
function startProfilerTimer(fiber) {
profilerStartTime = now();
0 > fiber.actualStartTime && (fiber.actualStartTime = now());
0 > fiber.actualStartTime && (fiber.actualStartTime = profilerStartTime);
}
function stopProfilerTimerIfRunningAndRecordDelta(fiber, overrideBaseTime) {
if (0 <= profilerStartTime) {
Expand Down Expand Up @@ -16413,11 +16413,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-modern-66cf2cfc-20240910",
version: "19.0.0-www-modern-a5a7f106-20240910",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-modern-a5a7f106-20240910"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16451,7 +16451,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-modern-66cf2cfc-20240910";
exports.version = "19.0.0-www-modern-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -10784,13 +10784,13 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1422 = {
bundleType: 0,
version: "19.0.0-www-classic-66cf2cfc-20240910",
version: "19.0.0-www-classic-a5a7f106-20240910",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: function () {
return null;
},
reconcilerVersion: "19.0.0-www-classic-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-classic-a5a7f106-20240910"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1423 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10816,4 +10816,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-classic-66cf2cfc-20240910";
exports.version = "19.0.0-www-classic-a5a7f106-20240910";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10298,13 +10298,13 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1414 = {
bundleType: 0,
version: "19.0.0-www-modern-66cf2cfc-20240910",
version: "19.0.0-www-modern-a5a7f106-20240910",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: function () {
return null;
},
reconcilerVersion: "19.0.0-www-modern-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-modern-a5a7f106-20240910"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1415 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10330,4 +10330,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-modern-66cf2cfc-20240910";
exports.version = "19.0.0-www-modern-a5a7f106-20240910";
12 changes: 6 additions & 6 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -7335,7 +7335,7 @@ __DEV__ &&
}
function startProfilerTimer(fiber) {
profilerStartTime = now();
0 > fiber.actualStartTime && (fiber.actualStartTime = now());
0 > fiber.actualStartTime && (fiber.actualStartTime = profilerStartTime);
}
function stopProfilerTimerIfRunningAndRecordDelta(fiber, overrideBaseTime) {
if (0 <= profilerStartTime) {
Expand Down Expand Up @@ -27704,11 +27704,11 @@ __DEV__ &&
: flushSyncErrorInBuildsThatSupportLegacyMode;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.0.0-www-classic-66cf2cfc-20240910" !== isomorphicReactPackageVersion)
if ("19.0.0-www-classic-a5a7f106-20240910" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.0.0-www-classic-66cf2cfc-20240910\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.0.0-www-classic-a5a7f106-20240910\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -27752,11 +27752,11 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-classic-66cf2cfc-20240910",
version: "19.0.0-www-classic-a5a7f106-20240910",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-classic-a5a7f106-20240910"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -28409,7 +28409,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-66cf2cfc-20240910";
exports.version = "19.0.0-www-classic-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
12 changes: 6 additions & 6 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -7193,7 +7193,7 @@ __DEV__ &&
}
function startProfilerTimer(fiber) {
profilerStartTime = now();
0 > fiber.actualStartTime && (fiber.actualStartTime = now());
0 > fiber.actualStartTime && (fiber.actualStartTime = profilerStartTime);
}
function stopProfilerTimerIfRunningAndRecordDelta(fiber, overrideBaseTime) {
if (0 <= profilerStartTime) {
Expand Down Expand Up @@ -26821,11 +26821,11 @@ __DEV__ &&
return_targetInst = null;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.0.0-www-modern-66cf2cfc-20240910" !== isomorphicReactPackageVersion)
if ("19.0.0-www-modern-a5a7f106-20240910" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.0.0-www-modern-66cf2cfc-20240910\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.0.0-www-modern-a5a7f106-20240910\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -26868,11 +26868,11 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-modern-66cf2cfc-20240910",
version: "19.0.0-www-modern-a5a7f106-20240910",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-modern-a5a7f106-20240910"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -27477,7 +27477,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-66cf2cfc-20240910";
exports.version = "19.0.0-www-modern-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17334,14 +17334,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1765 = React.version;
if (
"19.0.0-www-classic-66cf2cfc-20240910" !==
"19.0.0-www-classic-a5a7f106-20240910" !==
isomorphicReactPackageVersion$jscomp$inline_1765
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1765,
"19.0.0-www-classic-66cf2cfc-20240910"
"19.0.0-www-classic-a5a7f106-20240910"
)
);
function flushSyncFromReconciler(fn) {
Expand Down Expand Up @@ -17386,11 +17386,11 @@ Internals.Events = [
];
var internals$jscomp$inline_2259 = {
bundleType: 0,
version: "19.0.0-www-classic-66cf2cfc-20240910",
version: "19.0.0-www-classic-a5a7f106-20240910",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-classic-a5a7f106-20240910"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2260 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17846,4 +17846,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-66cf2cfc-20240910";
exports.version = "19.0.0-www-classic-a5a7f106-20240910";
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -16710,14 +16710,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1736 = React.version;
if (
"19.0.0-www-modern-66cf2cfc-20240910" !==
"19.0.0-www-modern-a5a7f106-20240910" !==
isomorphicReactPackageVersion$jscomp$inline_1736
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1736,
"19.0.0-www-modern-66cf2cfc-20240910"
"19.0.0-www-modern-a5a7f106-20240910"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -16735,11 +16735,11 @@ Internals.Events = [
];
var internals$jscomp$inline_2250 = {
bundleType: 0,
version: "19.0.0-www-modern-66cf2cfc-20240910",
version: "19.0.0-www-modern-a5a7f106-20240910",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-modern-a5a7f106-20240910"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2251 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17102,4 +17102,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-66cf2cfc-20240910";
exports.version = "19.0.0-www-modern-a5a7f106-20240910";
12 changes: 6 additions & 6 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4882,7 +4882,7 @@ var now = Scheduler.unstable_now,
nestedUpdateScheduled = !1;
function startProfilerTimer(fiber) {
profilerStartTime = now();
0 > fiber.actualStartTime && (fiber.actualStartTime = now());
0 > fiber.actualStartTime && (fiber.actualStartTime = profilerStartTime);
}
function stopProfilerTimerIfRunningAndRecordDelta(fiber, overrideBaseTime) {
if (0 <= profilerStartTime) {
Expand Down Expand Up @@ -18094,14 +18094,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1855 = React.version;
if (
"19.0.0-www-classic-66cf2cfc-20240910" !==
"19.0.0-www-classic-a5a7f106-20240910" !==
isomorphicReactPackageVersion$jscomp$inline_1855
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1855,
"19.0.0-www-classic-66cf2cfc-20240910"
"19.0.0-www-classic-a5a7f106-20240910"
)
);
function flushSyncFromReconciler(fn) {
Expand Down Expand Up @@ -18146,11 +18146,11 @@ Internals.Events = [
];
var internals$jscomp$inline_1862 = {
bundleType: 0,
version: "19.0.0-www-classic-66cf2cfc-20240910",
version: "19.0.0-www-classic-a5a7f106-20240910",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-66cf2cfc-20240910"
reconcilerVersion: "19.0.0-www-classic-a5a7f106-20240910"
};
enableSchedulingProfiler &&
((internals$jscomp$inline_1862.getLaneLabelMap = getLaneLabelMap),
Expand Down Expand Up @@ -18609,7 +18609,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-66cf2cfc-20240910";
exports.version = "19.0.0-www-classic-a5a7f106-20240910";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Loading

0 comments on commit b8a98ad

Please sign in to comment.