Skip to content

Commit

Permalink
Fix wrong deduplication condition
Browse files Browse the repository at this point in the history
  • Loading branch information
gaearon committed Dec 10, 2017
1 parent 51e3f49 commit abe0faf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/react-dom/src/client/ReactDOMFiberOption.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ function flattenChildren(children) {
export function validateProps(element: Element, props: Object) {
// TODO (yungsters): Remove support for `selected` in <option>.
if (__DEV__) {
if (!didWarnSelectedSetOnOption) {
if (props.selected != null && !didWarnSelectedSetOnOption) {
warning(
props.selected == null,
false,
'Use the `defaultValue` or `value` props on <select> instead of ' +
'setting `selected` on <option>.',
);
Expand Down

0 comments on commit abe0faf

Please sign in to comment.