Skip to content

Commit

Permalink
Don't dist-tag canaries with rc
Browse files Browse the repository at this point in the history
We used to tag canaries with `rc` whenever we were in the RC phase of
a release cycle. But now that publish "real" versioned canaries like
19.0.0-rc.1, it's confusing that the `rc` dist-tag could point to an
even newer version than that.

So this removes the `rc` dist-tag from the canary publish workflow.
  • Loading branch information
acdlite committed Nov 15, 2024
1 parent 63cde68 commit 71ebdd1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/runtime_prereleases_manual.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# because this used to be called the "next" channel and some
# downstream consumers might still expect that tag. We can remove this
# after some time has elapsed and the change has been communicated.
dist_tag: canary,next,rc
dist_tag: canary,next
secrets:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/runtime_prereleases_nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
with:
commit_sha: ${{ github.sha }}
release_channel: stable
dist_tag: canary,next,rc
dist_tag: canary,next
secrets:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand Down

0 comments on commit 71ebdd1

Please sign in to comment.