Null out deletions array instead of splicing 🤡

facebook · Jul 11, 2020 · 3ab5de1 · 3ab5de1
1 parent a5708e9
commit 3ab5de1
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js
@@ -2215,6 +2215,9 @@ function commitMutationEffects(
 ) {
   if (fiber.deletions !== null) {
     commitMutationEffectsDeletions(fiber.deletions, root, renderPriorityLevel);
+
+    // TODO (effects) Don't clear this yet; we may need to cleanup passive effects
+    fiber.deletions = null;
   }
 
   if (fiber.child !== null) {
@@ -2354,9 +2357,6 @@ function commitMutationEffectsDeletions(
     }
     // Don't clear the Deletion effect yet; we also use it to know when we need to detach refs later.
   }
-
-  // TODO (effects) Don't clear this yet; we may need to cleanup passive effects
-  deletions.splice(0);
 }
 
 function commitLayoutEffects(