Skip to content

Commit

Permalink
Exclude react-dom when flow checking other builds (#16737)
Browse files Browse the repository at this point in the history
This is because the HostConfig can't be guaranteed to be consistent with
other code such as code that touches the DOM directly.

Ideally we'd have a more systemic solution to this since it will pop
up for other packages later too.
  • Loading branch information
sebmarkbage authored Sep 19, 2019
1 parent fd870e6 commit 35bf9d2
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 4 deletions.
2 changes: 2 additions & 0 deletions scripts/flow/config/flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
.*/__mocks__/.*
.*/__tests__/.*

%REACT_RENDERER_FLOW_IGNORES%

[include]
../../../node_modules/
../../../packages/
Expand Down
21 changes: 17 additions & 4 deletions scripts/flow/createFlowConfigs.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,29 @@ function writeConfig(renderer, isFizzSupported) {
mkdirp.sync(folder);

const fizzRenderer = isFizzSupported ? renderer : 'custom';
const config = configTemplate.replace(
'%REACT_RENDERER_FLOW_OPTIONS%',
`
const config = configTemplate
.replace(
'%REACT_RENDERER_FLOW_OPTIONS%',
`
module.name_mapper='react-reconciler/inline.${renderer}$$' -> 'react-reconciler/inline-typed'
module.name_mapper='ReactFiberHostConfig$$' -> 'forks/ReactFiberHostConfig.${renderer}'
module.name_mapper='react-stream/inline.${renderer}$$' -> 'react-stream/inline-typed'
module.name_mapper='ReactFizzHostConfig$$' -> 'forks/ReactFizzHostConfig.${fizzRenderer}'
module.name_mapper='ReactFizzFormatConfig$$' -> 'forks/ReactFizzFormatConfig.${fizzRenderer}'
`.trim(),
);
)
.replace(
'%REACT_RENDERER_FLOW_IGNORES%',
renderer === 'dom' || renderer === 'dom-browser'
? ''
: // If we're not checking DOM, ignore the DOM package since it
// won't be consistent.
`
.*/packages/react-dom/.*
.*/packages/.*/forks/.*.dom.js
.*/packages/.*/forks/.*.dom-browser.js
`.trim(),
);

const disclaimer = `
# ---------------------------------------------------------------#
Expand Down

0 comments on commit 35bf9d2

Please sign in to comment.