Update AlertIOS.js #5789
Update AlertIOS.js #5789
Conversation
When using AlertIOS.prompt() the developer can't choose the input type, thus being forced to use 'plain-text'. This simple change allows to set input type ('secure-text' or 'login-password'), keeping as default 'plain-text'.
|
By analyzing the blame information on this pull request, we identified @corbt, @ericvicenti and @christopherdro to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Actually is this already implemented? AlertIOS was changed 16 days ago. Can you take a look at this commit ba4101d |
|
Not sure of how recently it has been implemented, but for sure it is not implemented until v0.19.0, which is the latest version available for installation through npm: https://github.com/facebook/react-native/blob/v0.19.0/Libraries/Utilities/AlertIOS.js |
|
You are right it is not in v0.19.0 but it will be in v0.20.0 |
|
Oh, you are trying to merge your changes in the facebook:0.17-stable branch instead of master, this is why the changes don't show in your diff. |
|
@39otrebla so it looks like you're basing your pull request off the 0.17 branch, instead of I updated the AlertIOS API a few weeks ago (#5286) and revamped it to match the change you're proposing, as well as a few other rationalizations of the API. It didn't quite make the cut for 0.19, but the updated version will be available in 0.20 (and the docs already include the new version). 0.20 will be released very soon, possibly today, so look forward to the new API! |
|
Actually sorry, it's just the RC being released today, not 0.20 stable, but it still has this change and typically the RC releases have been pretty safe to use, so I recommend you switch to it if you need this functionality. |
|
... The fact is that Official Documentation follows v0.20, so people may be confused to see Input Type as prompt() parameter and then receive an error. And it's there since days ago... But v0.20 has not been released yet, so options are 2: update v0.19 (or 0.17 and 0.18) to be documentation-compliant or release v0.20 . Well, since I can't release v0.20, I just thought it would be good to update branch which is commonly used by developers. |
|
RC1 for production? Nope sorry, so please either merge my commit v0.19 or do your one if you prefer, but developers who use v0.17, v0.18 and v0.19 may need this feature. |
|
@39otrebla The documentation is based on master, this is an issue that is currently being worked on to add versioned doc. I don't think there are any plans to support older stable versions so if you really need the feature I suggest that you use a fork until 0.20.0 is released. |
When using AlertIOS.prompt() the developer can't choose the input type, thus being forced to use 'plain-text'. This simple change allows to set input type ('secure-text' or 'login-password'), keeping as default 'plain-text'.