feat: add jsitooling package #49348
Closed
feat: add jsitooling package #49348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e34a3e to
cae7b67
Compare
b1c63df to
4684f64
Compare
cipolleschi
requested changes
Feb 12, 2025
packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.mm
Outdated
Show resolved
Hide resolved
a5566e6 to
6196368
Compare
6196368 to
1b01e94
Compare
cipolleschi
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
looks good to me.
I'll import this and ask @cortinico to review the CMakeLists.txt file
packages/react-native/ReactCommon/jsitooling/React-jsitooling.podspec
Outdated
Show resolved
Hide resolved
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
|
This is failing internally because we need to update the buck files to make it work. :( |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 31a8bb3. |
|
This pull request was successfully merged by @okwasniewski in 31a8bb3 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Note
This PR is part of JavaScriptCore Extraction to this repository: https://github.com/react-native-community/javascriptcore
This PR adds
jsitoolingpackage that third party JS engines can use (in that case javascriptcore). It's required because React-Runtime needs to depend on third-party engine on iOS, and the third-party engine needed to depend on React-Runtime to get access to theJSRuntimeFactoryand Cocoapods doesn't support circular dependencies...Now third-party engine can depenend on jsitooling package and provide JSRuntimeFactory
Changelog:
[INTERNAL] [ADDED] - jsitooling package
Test Plan:
CI Green