Fix some CSSRatio Behavior #48984
Closed
Fix some CSSRatio Behavior #48984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Noticed this in conjunction with another change, that I misinterpreted the ratio spec a bit. Ratios with a part less than zero are parse errors, while degenerate ratios are not (Chrome and Firefox both treat like this). Removing usage of visitorless `consumeComponentValue()` here in preparation for next diff. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68733519
|
This pull request was exported from Phabricator. Differential Revision: D68733519 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 28, 2025
Summary: Noticed this in conjunction with another change, that I misinterpreted the ratio spec a bit. Ratios with a part less than zero are parse errors, while degenerate ratios are not (Chrome and Firefox both treat like this). Removing usage of visitorless `consumeComponentValue()` here in preparation for next diff. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68733519
|
This pull request was successfully merged by @NickGerleman in 3b5dc56 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed this in conjunction with another change, that I misinterpreted the ratio spec a bit. Ratios with a part less than zero are parse errors, while degenerate ratios are not (Chrome and Firefox both treat like this).
Removing usage of visitorless
consumeComponentValue()here in preparation for next diff.Changelog: [Internal]
Reviewed By: lenaic
Differential Revision: D68733519