Fix possible NSOutOfRangeException when updating typing attributes in response to new text content #47737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… response to new text content Summary: We may see an NSOutOfRangeException when setting new AttributedString content, where setting the AttributedString itself changes selection (before we mutate it later). It seems like the selection here is not in a good state yet in regards to the AttributedString backing exposed (since we are reading it while modifying it). So let's fold the logic for updating typing attributes into the collection of ignored work from non-user-selection updates, since programatically setting an AttributedString will already trigger updating typing attributes. I also added a nil check here, which is unrelated to the crash, but it seems like we should have it for safety... Changelog: [iOS][Fixed] - Fix possible NSOutOfRangeException when updating typing attributes in response to new text content Differential Revision: D66202986
|
This pull request was exported from Phabricator. Differential Revision: D66202986 |
|
This pull request has been merged in 6e06a81. |
|
This pull request was successfully merged by @NickGerleman in 6e06a81 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Dec 4, 2024
…onse to new text content (#47737) Summary: Pull Request resolved: #47737 We may see an NSRangeException when setting new AttributedString content, where setting the AttributedString itself changes selection (before we mutate it later). It seems like the selection here is not in a good state yet in regards to the AttributedString backing exposed (since we are reading it while modifying it). So let's fold the logic for updating typing attributes into the collection of ignored work from non-user-selection updates, since programatically setting an AttributedString will already trigger updating typing attributes. I also added a nil check here, which is unrelated to the crash, but it seems like we should have it for safety... Changelog: [iOS][Fixed] - Fix possible NSRangeException when updating typing attributes in response to new text content Reviewed By: cipolleschi Differential Revision: D66202986 fbshipit-source-id: fded492b5022c5fef5b9563f93a57549d06a7020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We may see an NSOutOfRangeException when setting new AttributedString content, where setting the AttributedString itself changes selection (before we mutate it later).
It seems like the selection here is not in a good state yet in regards to the AttributedString backing exposed (since we are reading it while modifying it). So let's fold the logic for updating typing attributes into the collection of ignored work from non-user-selection updates, since programatically setting an AttributedString will already trigger updating typing attributes.
I also added a nil check here, which is unrelated to the crash, but it seems like we should have it for safety...
Changelog:
[iOS][Fixed] - Fix possible NSOutOfRangeException when updating typing attributes in response to new text content
Differential Revision: D66202986