Make RawPropsParser::iterateOverValues more performant #45088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58593492 |
Base commit: 4a8f0ee |
|
This pull request was exported from Phabricator. Differential Revision: D58593492 |
0646f58 to
f13fd4a
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jun 25, 2024
Summary: Pull Request resolved: facebook#45088 This diff should make iterator-style prop setting more performant. - It removes some layers of indirection. Now `ConcreteComponentDescriptor` calls into `setProp` directly. - On both platforms, we will use `folly::dynamic` parser, it seems it is slightly faster. - On Android, we will reuse `props->rawProps` parsed as a `folly::dynamic` representation, instead of parsing stuff twice. Changelog: [Internal] - This hasn't been rolled out to OSS yet. Reviewed By: sammy-SC Differential Revision: D58593492
|
This pull request was exported from Phabricator. Differential Revision: D58593492 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jun 25, 2024
Summary: Pull Request resolved: facebook#45088 This diff should make iterator-style prop setting more performant. - It removes some layers of indirection. Now `ConcreteComponentDescriptor` calls into `setProp` directly. - On both platforms, we will use `folly::dynamic` parser, it seems it is slightly faster. - On Android, we will reuse `props->rawProps` parsed as a `folly::dynamic` representation, instead of parsing stuff twice. Changelog: [Internal] - This hasn't been rolled out to OSS yet. Reviewed By: sammy-SC Differential Revision: D58593492
f13fd4a to
193b7dd
Compare
Summary: Pull Request resolved: facebook#45088 This diff should make iterator-style prop setting more performant. - It removes some layers of indirection. Now `ConcreteComponentDescriptor` calls into `setProp` directly. - On both platforms, we will use `folly::dynamic` parser, it seems it is slightly faster. - On Android, we will reuse `props->rawProps` parsed as a `folly::dynamic` representation, instead of parsing stuff twice. Changelog: [Internal] - This hasn't been rolled out to OSS yet. Reviewed By: javache Differential Revision: D58593492
|
This pull request was exported from Phabricator. Differential Revision: D58593492 |
193b7dd to
97e261b
Compare
dmytrorykun
pushed a commit
to dmytrorykun/react-native
that referenced
this pull request
Jun 25, 2024
Summary: Pull Request resolved: facebook#45088 This diff should make iterator-style prop setting more performant. - It removes some layers of indirection. Now `ConcreteComponentDescriptor` calls into `setProp` directly. - On both platforms, we will use `folly::dynamic` parser, it seems it is slightly faster. - On Android, we will reuse `props->rawProps` parsed as a `folly::dynamic` representation, instead of parsing stuff twice. Changelog: [Internal] - This hasn't been rolled out to OSS yet. Differential Revision: D58593492
dmytrorykun
pushed a commit
to dmytrorykun/react-native
that referenced
this pull request
Jun 25, 2024
Summary: Pull Request resolved: facebook#45088 This diff should make iterator-style prop setting more performant. - It removes some layers of indirection. Now `ConcreteComponentDescriptor` calls into `setProp` directly. - On both platforms, we will use `folly::dynamic` parser, it seems it is slightly faster. - On Android, we will reuse `props->rawProps` parsed as a `folly::dynamic` representation, instead of parsing stuff twice. Changelog: [Internal] - This hasn't been rolled out to OSS yet. Differential Revision: D58593492
|
This pull request has been merged in 1fda630. |
|
This pull request was successfully merged by @dmytrorykun in 1fda630. When will my fix make it into a release? | How to file a pick request? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff should make iterator-style prop setting more performant.
ConcreteComponentDescriptorcalls intosetPropdirectly.folly::dynamicparser, it seems it is slightly faster.props->rawPropsparsed as afolly::dynamicrepresentation, instead of parsing stuff twice.Changelog: [Internal] - This hasn't been rolled out to OSS yet.
Reviewed By: sammy-SC
Differential Revision: D58593492