Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'[skip ci] [RN][Android] Mark classes of package utils as @Nullsafe #42859

Closed
wants to merge 2 commits into from
Closed

'[skip ci] [RN][Android] Mark classes of package utils as @Nullsafe #42859

wants to merge 2 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Feb 4, 2024

Summary:
All these classes are NullSafe, let'''s mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Differential Revision: D53393475

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

9 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 6, 2024
@mdvacca @facebook-github-bot
Mark classes of package utils as @nullsafe (facebook#42859)
c984585 
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393475
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@analysis-bot
Copy link

analysis-bot commented Feb 6, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,233,687 -12
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,108 -12
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e37da1e
Branch: main

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 7, 2024
@mdvacca @facebook-github-bot
Mark classes of package utils as @nullsafe (facebook#42859)
af08e07 
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393475
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@mdvacca @facebook-github-bot
[skip ci] Mark nullability of RNLog class (facebook#42865)
2a8a75f 
Summary:

Mark nullability of RNLog class

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393953
@mdvacca @facebook-github-bot
Mark classes of package utils as @nullsafe (facebook#42859)
3af31d1 
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393475
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393475

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fe7b9e5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdvacca @facebook-github-bot @analysis-bot