Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Additional note for Android borderRadius clipping #3198 #4256

Merged
merged 1 commit into from
Nov 25, 2015
Merged

[Docs] Additional note for Android borderRadius clipping #3198 #4256

merged 1 commit into from
Nov 25, 2015

Conversation

rreusser
Copy link
Contributor

From known issues: "The overflow style property defaults to hidden and cannot be changed on Android"

This is not the full story. I was surprised to discover that although overflow: hidden is always true on Android, it never obeys borderRadius clipping. See: #3198. I think this is worth an extra sentence since there are design/implementation choices that can significantly simplify compensating for this, but only if known ahead of time.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @brentvatne, @mkonicek and @mbrock to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Nov 20, 2015
@brentvatne
Copy link
Collaborator

Modified it for clarity:

Another issue with overflow: 'hidden' on Android: a view is not clipped by the parent's borderRadius even if the parent has overflow: 'hidden' enabled -- the corners of the inner view will be visible outside of the rounded corners. This is only on Android -- it works as expected on iOS. See a demo of the bug and the corresponding issue.

Does this work for you? If so can you update PR?

@rreusser
Copy link
Contributor Author

Yup. Thanks! That's more clear. I've applied the changes. You can preview the markdown here

@facebook-github-bot
Copy link
Contributor

@rreusser updated the pull request.

@mkonicek
Copy link
Contributor

I'll let @brentvatne review this one.

@brentvatne
Copy link
Collaborator

lgtm!

brentvatne added a commit that referenced this pull request Nov 25, 2015
[Docs] Additional note for Android borderRadius clipping #3198
@brentvatne brentvatne merged commit a00bd33 into facebook:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants