New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCTDeprecation BUCK integration #41417

Closed

philIip wants to merge 3 commits into facebook:main from philIip:export-D51101009

Contributor

philIip commented Nov 11, 2023

Summary:
Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Nov 11, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

facebook-github-bot added the fb-exported label

analysis-bot commented Nov 11, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,646,672	+1
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,034,081	+5
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 917fd25
Branch: main

Contributor

facebook-github-bot commented Nov 11, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

1fce2be

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

2b2a6ce

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

bb7f4ac

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from 38a715e to 2b2a6ce Compare

November 11, 2023 05:01

Contributor

facebook-github-bot commented Nov 11, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from 2b2a6ce to c60ae49 Compare

November 11, 2023 05:27

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

02a9183

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from c60ae49 to d4fb85a Compare

November 14, 2023 01:03

Contributor

facebook-github-bot commented Nov 14, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

84a4051

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from d4fb85a to 84a4051 Compare

November 14, 2023 01:04

Contributor

facebook-github-bot commented Nov 14, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from 84a4051 to 9a78d82 Compare

November 14, 2023 21:05

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

021c89f

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

eaeee75

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

Contributor

facebook-github-bot commented Nov 14, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

f441475

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from 9a78d82 to f441475 Compare

November 14, 2023 21:05

Contributor

facebook-github-bot commented Nov 14, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from f441475 to d6fc022 Compare

November 14, 2023 21:28

Contributor

facebook-github-bot commented Nov 14, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from d6fc022 to 1b1cad7 Compare

November 16, 2023 20:03

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

1b1cad7

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from b90dd4b to 86effd5 Compare

November 17, 2023 06:15

Contributor

facebook-github-bot commented Nov 17, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

b92256b

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from 86effd5 to b92256b Compare

November 17, 2023 23:19

Contributor

facebook-github-bot commented Nov 17, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from b92256b to d42725b Compare

November 18, 2023 16:26

Contributor

facebook-github-bot commented Nov 18, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

f366f4b

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

658cbaa

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

a586cb0

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from d42725b to a586cb0 Compare

November 18, 2023 16:28

Contributor

facebook-github-bot commented Nov 18, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

00123d9

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from a586cb0 to 00123d9 Compare

November 18, 2023 16:56

Contributor

facebook-github-bot commented Nov 18, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

6a2fc9a

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

cb96390

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from 00123d9 to cb96390 Compare

November 18, 2023 16:56

Contributor

facebook-github-bot commented Nov 18, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

philIip added 3 commits

November 18, 2023 22:06


          introduce ReactApple (facebook#41419)

8dd2889

Summary:

Changelog: [iOS][something]

Creating a new top level directory for Apple platform specific code.

Reviewed By: christophpurrer

Differential Revision: D51170984


          introduce RCTFoundation (facebook#41418)

ac75468

Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983


          RCTDeprecation BUCK integration (facebook#41417)

a7e8a47

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

philIip force-pushed the export-D51101009 branch from cb96390 to a7e8a47 Compare

November 19, 2023 06:06

philIip added a commit to philIip/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

0d16467

Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

Contributor

facebook-github-bot commented Nov 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51101009

facebook-github-bot closed this in

c06beae

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Nov 19, 2023

This pull request has been merged in c06beae.

Othinn pushed a commit to Othinn/react-native that referenced this pull request


          RCTDeprecation BUCK integration (facebook#41417)

491fed3

Summary:
Pull Request resolved: facebook#41417

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009

fbshipit-source-id: fe828b64c7fd939f8576a496478b6a401bfae69c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner