Implement clientTop/clientLeft in ReadOnlyElement #39308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49009140 |
Base commit: 2608a37 |
|
This pull request was exported from Phabricator. Differential Revision: D49009140 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 6, 2023
Summary: Pull Request resolved: facebook#39308 This adds a new method in Fabric to get the border size for an element, and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : * `clientLeft`: left border width of the element. * `clientTop`: top border width of the element. If the element isn't displayed or it has display: inline, it return 0 in both cases. These APIs provide rounded integers. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D49009140 fbshipit-source-id: aec2d2f907339aa45e28271100c89b954f816cef
faa3590 to
f1ae460
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49009140 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2023
Summary: Pull Request resolved: facebook#39308 This adds a new method in Fabric to get the border size for an element, and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : * `clientLeft`: left border width of the element. * `clientTop`: top border width of the element. If the element isn't displayed or it has display: inline, it return 0 in both cases. These APIs provide rounded integers. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D49009140 fbshipit-source-id: 477f41537c7eba550cd7f1c1f3e1844617de61ab
f1ae460 to
3e44353
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49009140 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2023
Summary: Pull Request resolved: facebook#39308 This adds a new method in Fabric to get the border size for an element, and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : * `clientLeft`: left border width of the element. * `clientTop`: top border width of the element. If the element isn't displayed or it has display: inline, it return 0 in both cases. These APIs provide rounded integers. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D49009140 fbshipit-source-id: 18118bf965ef7f3f3fde79e85a41d83c04e97cdf
3e44353 to
486c5fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49009140 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2023
Summary: Pull Request resolved: facebook#39308 This adds a new method in Fabric to get the border size for an element, and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : * `clientLeft`: left border width of the element. * `clientTop`: top border width of the element. If the element isn't displayed or it has display: inline, it return 0 in both cases. These APIs provide rounded integers. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D49009140 fbshipit-source-id: 0b2ed15de4ea1e7fcb8961f879a77c1488558153
486c5fe to
081b093
Compare
Differential Revision: D48951824 fbshipit-source-id: 1bb73a87c65cd0be283a4887d21a0548d75157ec
Differential Revision: D49008698 fbshipit-source-id: 1db1f8d2d35caaab883556896fed7115536c90dc
Summary: Pull Request resolved: facebook#39308 This adds a new method in Fabric to get the border size for an element, and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : * `clientLeft`: left border width of the element. * `clientTop`: top border width of the element. If the element isn't displayed or it has display: inline, it return 0 in both cases. These APIs provide rounded integers. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D49009140 fbshipit-source-id: 7cc2fac1ec0526a5ad441bf71039333e10ff9696
|
This pull request was exported from Phabricator. Differential Revision: D49009140 |
081b093 to
c3975b8
Compare
|
This pull request has been merged in eb5e7b2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds a new method in Fabric to get the border size for an element, and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 :
clientLeft: left border width of the element.clientTop: top border width of the element.If the element isn't displayed or it has display: inline, it return 0 in both cases.
These APIs provide rounded integers.
Changelog: [internal]
Differential Revision: D49009140