Make sure the -DANDROID compilation flag is always included. #37451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45908787 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45908787 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 17, 2023
…k#37451) Summary: Pull Request resolved: facebook#37451 It seems like starting from AGP 7.4, Android is not including the `-DANDROID` flag anymore from the NDK toolchain. As we do have several `#ifdef` logic that takes care of having this macro set, I'm going to make sure it's always set for both ReactAndroid, hermes-engine and the template. Changelog: [Android] [Fixed] - Make sure the -DANDROID compilation flag is always included Reviewed By: javache Differential Revision: D45908787 fbshipit-source-id: ee28c9a6a314ead3a2bb74a3c9eb429c73e0bed0
fa82c3f to
fc7a216
Compare
Base commit: f7dcc65 |
…k#37451) Summary: Pull Request resolved: facebook#37451 It seems like starting from AGP 7.4, Android is not including the `-DANDROID` flag anymore from the NDK toolchain. As we do have several `#ifdef` logic that takes care of having this macro set, I'm going to make sure it's always set for both ReactAndroid, hermes-engine and the template. Changelog: [Android] [Fixed] - Make sure the -DANDROID compilation flag is always included Reviewed By: javache Differential Revision: D45908787 fbshipit-source-id: 2b67ba61f28d01446d2d6b6230a2ca94e7f60e86
|
This pull request was exported from Phabricator. Differential Revision: D45908787 |
fc7a216 to
2d62c0f
Compare
|
This pull request has been merged in 3a321ae. |
kelset
pushed a commit
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: #37451 It seems like starting from AGP 7.4, Android is not including the `-DANDROID` flag anymore from the NDK toolchain. As we do have several `#ifdef` logic that takes care of having this macro set, I'm going to make sure it's always set for both ReactAndroid, hermes-engine and the template. Changelog: [Android] [Fixed] - Make sure the -DANDROID compilation flag is always included Reviewed By: javache Differential Revision: D45908787 fbshipit-source-id: 07284712d7bcce73dc8ea0dffd4a9d00af4de1d2
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It seems like starting from AGP 7.4, Android is not including the
-DANDROIDflaganymore from the NDK toolchain.
As we do have several
#ifdeflogic that takes care of having this macro set,I'm going to make sure it's always set for both ReactAndroid, hermes-engine
and the template.
Changelog:
[Android] [Fixed] - Make sure the -DANDROID compilation flag is always included
Differential Revision: D45908787