Buck: renamed rn_library() kwarg: native_module_android_package_name -> android_package_name #36867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D44857744 |
Base commit: 71506ce |
|
This pull request was exported from Phabricator. Differential Revision: D44857744 |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 11, 2023
…-> android_package_name (facebook#36867) Summary: Pull Request resolved: facebook#36867 This will make it consistent with rn_codegen() kwargs, and because android_package_name is not just limited to native_module's Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D44857744 fbshipit-source-id: d8a0b4000b2f2fa4ffda4454d1c9dc90402b39bb
95bde9e to
5505241
Compare
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 11, 2023
…-> android_package_name (facebook#36867) Summary: Pull Request resolved: facebook#36867 This will make it consistent with rn_codegen() kwargs, and because android_package_name is not just limited to native_module's Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D44857744 fbshipit-source-id: b0dd61a17474648dd04374447feff5236c5c0e67
5505241 to
52b072a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44857744 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44857744 |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 11, 2023
…-> android_package_name (facebook#36867) Summary: Pull Request resolved: facebook#36867 This will make it consistent with rn_codegen() kwargs, and because android_package_name is not just limited to native_module's Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D44857744 fbshipit-source-id: 49e9251ebdd6df8f78ddf73fa0324c1dc1ab8e74
52b072a to
f0cb850
Compare
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 11, 2023
…-> android_package_name (facebook#36867) Summary: Pull Request resolved: facebook#36867 This will make it consistent with rn_codegen() kwargs, and because android_package_name is not just limited to native_module's Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D44857744 fbshipit-source-id: c296c11f2e68f3ed01ae87463c3c13f0f4933798
f0cb850 to
a05ee98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44857744 |
Summary: For consistency with internal build rules, rename this kwarg. This will make it easier to keep both internal and external usages consistent. Changelog: [General][Changed] react-native-codegen: Buck-only: renamed src_prefix kwarg Differential Revision: D44857745 fbshipit-source-id: 5027c1358fd1987a66a81590d9d8d8622ab709b8
…-> android_package_name (facebook#36867) Summary: Pull Request resolved: facebook#36867 This will make it consistent with rn_codegen() kwargs, and because android_package_name is not just limited to native_module's Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D44857744 fbshipit-source-id: 7904a34cfaf2e2bf4b87e2ce10d19a2cfda7af54
|
This pull request was exported from Phabricator. Differential Revision: D44857744 |
a05ee98 to
3d3e2ed
Compare
|
This pull request has been merged in 511bf4f. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…-> android_package_name (facebook#36867) Summary: Pull Request resolved: facebook#36867 This will make it consistent with rn_codegen() kwargs, and because android_package_name is not just limited to native_module's Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D44857744 fbshipit-source-id: 37a8a69b443ffc8bfbaa145b0f21270a0f3515d4
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…-> android_package_name (facebook#36867) Summary: Pull Request resolved: facebook#36867 This will make it consistent with rn_codegen() kwargs, and because android_package_name is not just limited to native_module's Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D44857744 fbshipit-source-id: 37a8a69b443ffc8bfbaa145b0f21270a0f3515d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will make it consistent with rn_codegen() kwargs, and because android_package_name is not just limited to native_module's
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D44857744