Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FabricMountItem.* to CppMountItem.* #36722

Closed
wants to merge 1 commit into from

Conversation

veviego
Copy link

@veviego veviego commented Mar 30, 2023

Summary:

Changelog: [Android] [Breaking] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Differential Revision: D44540079

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 30, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

@analysis-bot
Copy link

analysis-bot commented Mar 30, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,603,861 -687
android hermes armeabi-v7a 7,917,847 +42
android hermes x86 9,089,715 -495
android hermes x86_64 8,944,777 +116
android jsc arm64-v8a 9,173,449 -690
android jsc armeabi-v7a 8,365,195 +41
android jsc x86 9,231,109 -476
android jsc x86_64 9,489,755 +105

Base commit: 0858853
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

@veviego veviego force-pushed the export-D44540079 branch from da9bb3d to 0f18878 Compare April 3, 2023 01:44
veviego pushed a commit to veviego/react-native that referenced this pull request Apr 3, 2023
Summary:
Pull Request resolved: facebook#36722

Changelog: [Android][Fixed] Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: f40ac14fbca6ec1875ef014cd741ced5915e8a89
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

veviego pushed a commit to veviego/react-native that referenced this pull request Apr 3, 2023
Summary:
Changelog: [Android][Fixed] Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: cc338933b80b64c3a856b7d029d181b3477334e2
@veviego veviego force-pushed the export-D44540079 branch from 0f18878 to cf1adf8 Compare April 3, 2023 12:00
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

veviego pushed a commit to veviego/react-native that referenced this pull request Apr 3, 2023
Summary:
Changelog: [Android][Fixed] Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: 4786b8522d40ef3a469d19e4a594137481782e0b
@veviego veviego force-pushed the export-D44540079 branch from cf1adf8 to b94c048 Compare April 3, 2023 12:06
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

veviego pushed a commit to veviego/react-native that referenced this pull request Apr 4, 2023
Summary:
Changelog: [Android] [Fixed] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: 4c3b0a91235522a56245bf41bae10829fb97b7ae
@veviego veviego force-pushed the export-D44540079 branch from b94c048 to 8490332 Compare April 4, 2023 04:04
veviego pushed a commit to veviego/react-native that referenced this pull request Apr 4, 2023
Summary:
Changelog: [Android] [Fixed] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: 71e3edab7f7fb2a2fc946f6c5ce47d0610868af0
@veviego veviego force-pushed the export-D44540079 branch from 8490332 to 0fd129d Compare April 4, 2023 04:11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Apr 4, 2023
veviego pushed a commit to veviego/react-native that referenced this pull request Apr 4, 2023
Summary:
Changelog: [Android] [Fixed] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: 21edf92f0119a63afa79c75e88d001f8c458dab2
@veviego veviego force-pushed the export-D44540079 branch from 0fd129d to e1fbfbd Compare April 4, 2023 04:27
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

veviego pushed a commit to veviego/react-native that referenced this pull request Apr 4, 2023
Summary:
Changelog: [Android] [Fixed] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: 24691026a2863588a2c7b943563570cf78c76124
@veviego veviego force-pushed the export-D44540079 branch from e1fbfbd to 3416b98 Compare April 4, 2023 04:33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

veviego pushed a commit to veviego/react-native that referenced this pull request Apr 4, 2023
Summary:
Changelog: [Android] [Fixed] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: 4bbc0af7e440437d785707c65a2cf02146de9a6c
@veviego veviego force-pushed the export-D44540079 branch from 3416b98 to 20d2fc5 Compare April 4, 2023 11:14
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

veviego pushed a commit to veviego/react-native that referenced this pull request Apr 4, 2023
Summary:
Changelog: [Android] [Fixed] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: 26de7c0a32b5e202ce5fdf226ed3088da0c3c191
@veviego veviego force-pushed the export-D44540079 branch from 20d2fc5 to 662f62c Compare April 4, 2023 11:18
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

@veviego veviego force-pushed the export-D44540079 branch from 662f62c to d03c27b Compare April 5, 2023 15:29
veviego pushed a commit to veviego/react-native that referenced this pull request Apr 5, 2023
Summary:
Changelog: [Android] [Fixed] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: javache

Differential Revision: D44540079

fbshipit-source-id: 83608942e6719f17baca533194d8180ffb2d28e6
Summary:
Changelog: [Android] [Breaking] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: cortinico, cipolleschi

Differential Revision: D44540079

fbshipit-source-id: cb64dc17a8b4a7250e71d74944841d6a65534e66
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44540079

@veviego veviego force-pushed the export-D44540079 branch from d03c27b to dbd4c6d Compare April 6, 2023 10:53
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 49f1237.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Changelog: [Android] [Breaking] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: cortinico, cipolleschi

Differential Revision: D44540079

fbshipit-source-id: 79d8aa7c6f6b908be52009c51c4ea2f601f788fd
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Changelog: [Android] [Breaking] - Renamed FabricMountItem.* files to MountItem.* to better match the name of the struct.

Pull Request resolved: facebook#36722

Reviewed By: cortinico, cipolleschi

Differential Revision: D44540079

fbshipit-source-id: 79d8aa7c6f6b908be52009c51c4ea2f601f788fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants