Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont mess up EXCLUDED_ARCHS[sdk=iphonesimulator*] after pod install #35814

Closed
wants to merge 1 commit into from

Conversation

pvinis
Copy link
Contributor

@pvinis pvinis commented Jan 12, 2023

Summary

#31118

When running pod install on an M1 machine, the xcodeproj file is messed up and while it works for M1 machines, it doesn't on other non-M1 machines, and also doesn't work on ci, since usually they don't use M1s.

This change makes sure that it will not mess with the xcodeproj file.

some real world usage:

Changelog

Test Plan

You can try to run pod install on an m1 and a non-m1, and see that the EXCLUDED_ARCHS[sdk=iphonesimulator*] don't change.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 12, 2023
@pvinis
Copy link
Contributor Author

pvinis commented Jan 12, 2023

woops. i think i had it flipped. nvm.

@pvinis pvinis closed this Jan 12, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,493,485 +0
android hermes armeabi-v7a 7,813,452 +0
android hermes x86 8,967,867 +0
android hermes x86_64 8,827,371 +0
android jsc arm64-v8a 9,679,111 +0
android jsc armeabi-v7a 8,412,818 +0
android jsc x86 9,742,216 +0
android jsc x86_64 10,220,841 +0

Base commit: 91397d4
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants