Fix onAccessibilityAction on Fabric #35507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactAccessibilityDelegate performAccessibilityAction dispatches the event topAccessibilityAction -- Understand why Fabric does not call registerEventEmitter before performAccessibilityAction for that reactTag/surfaceId Read StackTrace from error message (use printStacktrace) The method getUIManager retrieve the UIManager from the reactTag and does not check if is Fabric or Paper ReactAccessibilityDelegate [performAccessibilityAction](https://github.com/facebook/react-native/blob/bf37a34c38b39a14de8194520d07de0b9f8c0bf7/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java#L410-L415) dispatches the event topAccessibilityAction Understand why Fabric does not call [registerEventEmitter](https://github.com/fabriziobertoglio1987/react-native/blob/163171ccab6937785f4f3c85e011bd14540bebf5/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java#L426) before performAccessibilityAction for that reactTag/surfaceId Read StackTrace from [error message](facebook#30841 (comment)) (use [printStacktrace](https://www.google.com/search?q=java+printStacktrace)) The method [getUIManager](https://github.com/fabriziobertoglio1987/react-native/blob/dc4c54ec1b7b7f7cd37c7402b1eac5292cb4996a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerHelper.java#L40-L48) retrieve the UIManager from the reactTag and does not check if is Fabric or Paper
CLICK TO OPEN TESTS RESULTS
2022-11-29.17-02-00.mp4 |
Base commit: dccb57f |
Base commit: dccb57f |
|
PR build artifact for 69d43f8 is ready. |
|
PR build artifact for 69d43f8 is ready. |
philIip
approved these changes
Dec 3, 2022
|
@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: fixes facebook#30841 (comment). onAccessibilityAction does not work on Fabric and logs: ``` E/unknown:ReactEventEmitter( 3845): com.facebook.react.bridge.ReactNoCrashSoftException: Cannot find EventEmitter for receiveEvent: SurfaceId[1] ReactTag[104] UIManagerType[2] ``` ## Changelog [Android] [Fixed] - Fix onAccessibilityAction on Fabric Pull Request resolved: facebook#35507 Test Plan: facebook#35507 (comment) Reviewed By: javache Differential Revision: D41707777 Pulled By: philIip fbshipit-source-id: 0f4550a17f4b8bfc1aefa404059b367907f8f60d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #30841 (comment). onAccessibilityAction does not work on Fabric and logs:
Changelog
[Android] [Fixed] - Fix onAccessibilityAction on Fabric
Test Plan
#35507 (comment)