RNGP - Do the .so cleanup using pickFirst and exclude #35093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It turns out that using the Artifacts API to manipulate the APK to remove .so has unintended side effects and is causing the `installDebug` and `installRelease` commands to fail. I've resorted to register a packaging option for each variant to make sure we include only the correct artifacts we want. This should fix the current startup crash that is experienced on main. Changelog: [Android] [Fixed] - RNGP - Do the .so cleanup using pickFirst and exclude Differential Revision: D40722285 fbshipit-source-id: 9d933551cbc0ed39b753b84d3398e1fc8b7c6641
|
This pull request was exported from Phabricator. Differential Revision: D40722285 |
Base commit: 925e81a |
Base commit: 925e81a |
|
PR build artifact for bc3f31e is ready. |
|
PR build artifact for bc3f31e is ready. |
cortinico
referenced
this pull request
Oct 26, 2022
Summary: Pull Request resolved: #35063 This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. Here I'm add Variant support to RNGP via the Variant API from AGP 7.x A short summary of changes: - I've pushed a number of breaking changes to ReactExtension (we should document them in the release notes). Specifically I've removed properties which I believe were unnecessary and confusing - I've removed all the extra logic to do the .so cleanups and use the new tasks that use the Artifacts API - I've introduced only a `debuggableVariants` to make all the decisions for the bundling and minification which should be sufficient for users - I've removed all the funcional interfaces are replaced them with lists as they're easy to handle and understand for users. Changelog: [Android] [Changed] - Added Flavor Support to React Native Gradle Plugin (RNGP) Reviewed By: cipolleschi Differential Revision: D40335028 fbshipit-source-id: d9ac1437de8a27db2e93df15b13772b221e036b2
|
This pull request was successfully merged by @cortinico in 2ff08e8. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35093 It turns out that using the Artifacts API to manipulate the APK to remove .so has unintended side effects and is causing the `installDebug` and `installRelease` commands to fail. I've resorted to register a packaging option for each variant to make sure we include only the correct artifacts we want. This should fix the current startup crash that is experienced on main. Changelog: [Android] [Fixed] - RNGP - Do the .so cleanup using pickFirst and exclude Reviewed By: cipolleschi Differential Revision: D40722285 fbshipit-source-id: 982e1e9c474522fc4419c969ede5ee14e5404f3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It turns out that using the Artifacts API to manipulate the APK to remove
.so has unintended side effects and is causing the
installDebugandinstallReleasecommands to fail.
I've resorted to register a packaging option for each variant to make sure we include only
the correct artifacts we want.
This should fix the current startup crash that is experienced on main.
Changelog:
[Android] [Fixed] - RNGP - Do the .so cleanup using pickFirst and exclude
Differential Revision: D40722285