Replace Toast with Log.w on ReactImageView when null URL specified #34819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is crashing on A12 because of using the regular Context instead of the application context. That said, this probably makes more sense as a log warning. Reviewed By: javache Differential Revision: D39852058 fbshipit-source-id: 8bec3320558edcdb034045322e2eaff5f6a37899
|
This pull request was exported from Phabricator. Differential Revision: D39852058 |
Base commit: 427ce5f |
Base commit: 427ce5f |
|
This pull request was successfully merged by Christopher Jones in 30411ae. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…acebook#34819) Summary: Pull Request resolved: facebook#34819 This is crashing on A12 because of using the regular Context instead of the application context. That said, this probably makes more sense as a log warning. Reviewed By: javache Differential Revision: D39852058 fbshipit-source-id: 1ac93f8cc9ecdb14f60baca175c8ecff2ff42ac0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is crashing on A12 because of using the regular Context instead of the application context. That said, this probably makes more sense as a log warning.
Reviewed By: javache
Differential Revision: D39852058
Changelog
[Android][Changed] - Replaces a Toast warning with a Log warning on ReactImageView to prevent a crash on A12.