Fix items disappear when zooming VirtualizedList #33765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungsters
reviewed
May 5, 2022
| @@ -47,6 +47,7 @@ type Context = $ReadOnly<{ | |||
| timestamp: number, | |||
| velocity: number, | |||
| visibleLength: number, | |||
| ... | |||
There was a problem hiding this comment.
Why not add zoomScale: number here?
|
@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
yungsters
requested changes
May 5, 2022
| @@ -25,12 +25,13 @@ export function elementsThatOverlapOffsets( | |||
| offset: number, | |||
| ... | |||
| }, | |||
| zoomScale: number, | |||
There was a problem hiding this comment.
This requires calls in VirtualizeUtils-test.js to be updated. Otherwise, the Jest test fails.
There was a problem hiding this comment.
Fixed so that the test passes.
|
@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @islandryu in 13a72e0. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #33705
Fixed the disappearance of items when scrolling after zooming VirtualizedList.
example https://github.com/islandryu/zoomVirtualizedList
Before modification
2022-05-05.9.23.40.mov
After modification
2022-05-05.14.42.05.mov
Changelog
[General] [Fixed] - Fixed the disappearance of items when scrolling after zooming VirtualizedList.
Test Plan
Make the VirtualizedList zoomable with a prop such as maximumZoomScale.
Apply the patch and make sure that items in the VirtualizedList do not disappear when you scroll after zooming the VirtualizedList.
Or apply the patch from this repository and check it.
https://github.com/islandryu/zoomVirtualizedList