Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn.lock #30361

Closed

Conversation

mkcode
Copy link
Contributor

@mkcode mkcode commented Nov 10, 2020

This yarn.lock file was regenerated by deleting the existing yarn.lock file and rerunning yarn install.

Summary

The current yarn.lock file is fairly out of date and is affecting the CI servers.

More specifically, fsevents@1.2.7, referenced in yarn.lock here, fails to compile on node 12 or later.

This causes the yarn install step on CI to error.

This PR is being made as 1 step in getting the RNTester detox tests running again.

We can alternatively manually update the yarn.lock file with the minimum needed fsevent changes if this PR changes too much.

Changelog

[Internal] [Changed] - Bump fsevents from 1.2.7 to 1.2.13.

Test Plan

Verify yarn install step on CI is fixed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2020
@mkcode
Copy link
Contributor Author

mkcode commented Nov 10, 2020

@analysis-bot
Copy link

analysis-bot commented Nov 10, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0e9296b

@analysis-bot
Copy link

analysis-bot commented Nov 10, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,524,788 +0
android hermes armeabi-v7a 7,110,030 +0
android hermes x86 7,965,256 +0
android hermes x86_64 7,876,556 +0
android jsc arm64-v8a 8,989,250 +0
android jsc armeabi-v7a 8,557,601 +0
android jsc x86 8,991,225 +0
android jsc x86_64 9,542,782 +0

Base commit: 0e9296b

@rickhanlonii rickhanlonii requested a review from cpojer November 10, 2020 20:11
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead only remove fsevents from yarn.lock and re-run Yarn? We don't want all dependencies to be updated like this.

The changes here are caused by bumping fsevents@1.2.7 to 1.2.13.
@mkcode mkcode force-pushed the update-yarn-lock-fsevents branch from 67b249f to 38fd076 Compare November 12, 2020 00:12
@mkcode
Copy link
Contributor Author

mkcode commented Nov 12, 2020

@cpojer - Changes made and yarn install step on CI looks good. The 1 CI failure is the same as master.

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's much better!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mkcode in 0bbab02.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants