-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update yarn.lock #30361
Update yarn.lock #30361
Conversation
Yarn install step on CI looks better with these changes: https://app.circleci.com/pipelines/github/facebook/react-native/7069/workflows/ce93e1d1-64a5-4bfe-9798-d9744dcd8505/jobs/176303/parallel-runs/0/steps/0-104 |
Base commit: 0e9296b |
Base commit: 0e9296b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you instead only remove fsevents from yarn.lock and re-run Yarn? We don't want all dependencies to be updated like this.
The changes here are caused by bumping fsevents@1.2.7 to 1.2.13.
67b249f
to
38fd076
Compare
@cpojer - Changes made and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, that's much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @mkcode in 0bbab02. When will my fix make it into a release? | Upcoming Releases |
This yarn.lock file was regenerated by deleting the existing yarn.lock file and rerunning
yarn install
.Summary
The current
yarn.lock
file is fairly out of date and is affecting the CI servers.More specifically, fsevents@1.2.7, referenced in yarn.lock here, fails to compile on node 12 or later.
This causes the yarn install step on CI to error.
This PR is being made as 1 step in getting the RNTester detox tests running again.
We can alternatively manually update the
yarn.lock
file with the minimum needed fsevent changes if this PR changes too much.Changelog
[Internal] [Changed] - Bump fsevents from 1.2.7 to 1.2.13.
Test Plan
Verify yarn install step on CI is fixed.