Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(eslint-config): update eslint-plugin-react-native #30350

Conversation

Naturalclar
Copy link
Contributor

Summary

Currently, installing @react-native-community/eslint-config with projects using eslint v7 causes the following warning

warning "@react-native-community/eslint-config > eslint-plugin-react-native@3.8.1" has incorrect peer dependency "eslint@^3.17.0 || ^4 || ^5 || ^6".

This PR updates the eslint-plugin-react-native module to suppress the warning

Changelog

[Internal] [Changed] - update eslint-plugin-react-native for community eslint-config

Test Plan

eslint working without error with projects using eslint v7

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2020
@analysis-bot
Copy link

analysis-bot commented Nov 9, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 26787e2

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,507,188 -17,876
android hermes armeabi-v7a 7,098,964 -11,022
android hermes x86 7,945,335 -19,802
android hermes x86_64 7,856,391 -20,072
android jsc arm64-v8a 8,971,903 -17,776
android jsc armeabi-v7a 8,546,801 -10,924
android jsc x86 8,971,534 -19,726
android jsc x86_64 9,522,859 -19,981

Base commit: 8e956b3

@nadiia nadiia self-assigned this Dec 10, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadiia has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link

@nadiia nadiia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naturalclar Thank you for the fix!

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Naturalclar in 3cebd35.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 14, 2020
@Naturalclar Naturalclar deleted the chore/updateEslintPluginReactNative branch December 15, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants