Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'qs' dependency, update yarn lock #30125

Closed
wants to merge 1 commit into from

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Oct 7, 2020

Summary

This PR removes unused qs package (query string parser) from the main package.json file.

I was not able to find any explicit usage of this package in the repository. Looking at the commit which introduced this package it is not clear why it has been added, query string is not processed in any way.

I have also run yarn update-lock to clean up lock after latest dependencies bumps. There are no qs package entry removal in yarn lock, because it is already required by request package.

Refs: b4785e5

Changelog

[Internal] [Removed] - remove unused qs dependency

Test Plan

This change should not affect the code base.

@Simek Simek requested review from cpojer and hramos as code owners October 7, 2020 18:09
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2020
@pull-bot
Copy link

pull-bot commented Oct 7, 2020

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 8401b4c

@analysis-bot
Copy link

analysis-bot commented Oct 7, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,385,801 0
android hermes armeabi-v7a 7,013,117 0
android hermes x86 7,828,013 0
android hermes x86_64 7,717,499 0
android jsc arm64-v8a 9,532,102 0
android jsc armeabi-v7a 9,147,130 0
android jsc x86 9,396,778 0
android jsc x86_64 9,978,488 0

Base commit: 8e943d8

@analysis-bot
Copy link

analysis-bot commented Oct 7, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 8e943d8

@Simek Simek force-pushed the chore-remove-unused-qs branch from 0dbcac3 to 51872a0 Compare October 7, 2020 22:46
@Simek Simek force-pushed the chore-remove-unused-qs branch from 51872a0 to 8401b4c Compare October 7, 2020 22:51
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Simek in 38bc5df.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants