-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'qs' dependency, update yarn lock #30125
Conversation
Base commit: 8e943d8 |
Base commit: 8e943d8 |
0dbcac3
to
51872a0
Compare
51872a0
to
8401b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @Simek in 38bc5df. When will my fix make it into a release? | Upcoming Releases |
Summary
This PR removes unused
qs
package (query string parser) from the mainpackage.json
file.I was not able to find any explicit usage of this package in the repository. Looking at the commit which introduced this package it is not clear why it has been added, query string is not processed in any way.
I have also run
yarn update-lock
to clean up lock after latest dependencies bumps. There are noqs
package entry removal in yarn lock, because it is already required byrequest
package.Refs: b4785e5
Changelog
[Internal] [Removed] - remove unused
qs
dependencyTest Plan
This change should not affect the code base.