-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CircleCI breakage in RCTPropsAnimatedNode #29800
Conversation
Differential Revision: D23146036 fbshipit-source-id: d407c11992ce739cae8cb1482aabadf407d920a2
Summary: I changed this line in D23272735 (facebook@700960c), to conform to normal ObjC semantics: impl files can import their header by file name. I forgot that their's some special linking logic happening in this directory that doesn't allow for this import type. This diff just reverts one line to fix CircleCI builds. Changelog: [Internal] Differential Revision: D23399893 fbshipit-source-id: 1071af66d9279304921dc10d167e04794ae93180
This pull request was exported from Phabricator. Differential Revision: D23399893 |
|
Base commit: 6729a3e |
Base commit: 6729a3e |
This pull request was successfully merged by @PeteTheHeat in b231e3a. When will my fix make it into a release? | Upcoming Releases |
Summary: Pull Request resolved: facebook#29800 I changed this line in D23272735 (facebook@700960c), to conform to normal ObjC semantics: impl files can import their header by file name. I forgot that their's some special linking logic happening in this directory that doesn't allow for this import type. This diff just reverts one line to fix CircleCI builds. Changelog: [Internal] Reviewed By: shergin Differential Revision: D23399893 fbshipit-source-id: 976199c659522effd632aaeb38616d0d6c962f1f
Summary:
I changed this line in D23272735 (700960c), to conform to normal ObjC semantics: impl files can import their header by file name.
I forgot that their's some special linking logic happening in this directory that doesn't allow for this import type.
This diff just reverts one line to fix CircleCI builds.
Changelog: [Internal]
Differential Revision: D23399893