Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples to test tapping on overflowed Views to RNTesterApp #29393

Closed
wants to merge 1 commit into from

Conversation

hsource
Copy link
Contributor

@hsource hsource commented Jul 16, 2020

Summary

By default, Views in React Native have overflow: visible. When a child view is outside of the parent view's boundaries, it's visible on Android, but not tappable. This behaviour is incorrect, and doesn't match iOS behaviour.

#26374 and #29039 both fix this. @shergin suggested:

Can we start from decoupling the example from this diff for quick landing? We think we solved this issue in Fabric on iOS and Android, and the test will be very helpful to verify that.

This change does that.

Changelog

[Internal] [Added] - Added examples to test tapping on overflowed Views to RNTesterApp

Test Plan

Added tests to RNTesterApp. Here are the current results of testing on Android:

master With #29039 With #26374
20200716_011417 20200716_013136 20200716_013937

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2020
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Jul 16, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,765,114 991
android hermes armeabi-v7a 6,432,725 984
android hermes x86 7,152,808 991
android hermes x86_64 7,042,819 1,005
android jsc arm64-v8a 8,936,208 513
android jsc armeabi-v7a 8,596,204 505
android jsc x86 8,767,008 516
android jsc x86_64 9,342,651 506

Base commit: 9f699ae

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 9f699ae

@hsource hsource changed the title Added examples to test tapping on overflowed Views to RNTesterApp (Android) Added examples to test tapping on overflowed Views to RNTesterApp Aug 13, 2020
@hsource hsource changed the title (Android) Added examples to test tapping on overflowed Views to RNTesterApp Added examples to test tapping on overflowed Views to RNTesterApp Aug 14, 2020
@mrousavy
Copy link
Contributor

@shergin does this work on Fabric?

@hsource hsource closed this Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants