Bump FlipperKit version on iOS to be compatible with react-native-fli… #28225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pper This diff updated FlipperKit to be compatible with the latest react-native-flipper version. Tested by upgrading the ReactNativeFlipperExample (https://github.com/facebook/flipper/tree/master/react-native/ReactNativeFlipperExample) to RN 0.62.0-rc.3 and verified the example plugin works. (In D20221558)
awibox
approved these changes
Mar 4, 2020
|
|
RNTester.app (iOS): 10715136 bytes |
There was a problem hiding this comment.
@mweststrate has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
6 tasks
|
This pull request was successfully merged by @mweststrate in fbb94a3. When will my fix make it into a release? | Upcoming Releases |
alloy
pushed a commit
that referenced
this pull request
Mar 5, 2020
#28225) Summary: This diff updated FlipperKit to be compatible with the latest react-native-flipper version. (nothing changes compared to what is already in the changelog for RN 0.62.0) [iOS][Fixed] - Upgraded FlipperKit to 0.32.2 to ensure compatibility with latest `react-native-flipper` Pull Request resolved: #28225 Test Plan: Tested by upgrading the ReactNativeFlipperExample (https://github.com/facebook/flipper/tree/master/react-native/ReactNativeFlipperExample) to RN 0.62.0-rc.3 and verified the example plugin works. (In D20221558)  Reviewed By: priteshrnandgaonkar Differential Revision: D20249666 Pulled By: mweststrate fbshipit-source-id: 71a61c4249f8b767c7767d5c6133436c9bc9cf26
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
facebook#28225) Summary: This diff updated FlipperKit to be compatible with the latest react-native-flipper version. ## Changelog (nothing changes compared to what is already in the changelog for RN 0.62.0) [iOS][Fixed] - Upgraded FlipperKit to 0.32.2 to ensure compatibility with latest `react-native-flipper` Pull Request resolved: facebook#28225 Test Plan: Tested by upgrading the ReactNativeFlipperExample (https://github.com/facebook/flipper/tree/master/react-native/ReactNativeFlipperExample) to RN 0.62.0-rc.3 and verified the example plugin works. (In D20221558)  Reviewed By: priteshrnandgaonkar Differential Revision: D20249666 Pulled By: mweststrate fbshipit-source-id: 71a61c4249f8b767c7767d5c6133436c9bc9cf26
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 10, 2020
…pper (#28277) Summary: This pull request re-applies #28225, thereby reverting 4bb1794, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to facebook/flipper#874) This is the iOS counterpart of #28275 ## Changelog [iOS] [Changed] - Upgrade Flipper dependency to 0.33.1 Pull Request resolved: #28277 Test Plan: * Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there. * CI  Reviewed By: mweststrate Differential Revision: D20369106 Pulled By: TheSavior fbshipit-source-id: dfeb0446e7f29684a266eca5d0e29ac42cef2ef3
alloy
pushed a commit
that referenced
this pull request
Mar 11, 2020
…pper (#28277) Summary: This pull request re-applies #28225, thereby reverting 4bb1794, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to facebook/flipper#874) This is the iOS counterpart of #28275 [iOS] [Changed] - Upgrade Flipper dependency to 0.33.1 Pull Request resolved: #28277 Test Plan: * Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there. * CI  Reviewed By: mweststrate Differential Revision: D20369106 Pulled By: TheSavior fbshipit-source-id: dfeb0446e7f29684a266eca5d0e29ac42cef2ef3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This diff updated FlipperKit to be compatible with the latest react-native-flipper version.
Changelog
(nothing changes compared to what is already in the changelog for RN 0.62.0)
[iOS][Fixed] - Upgraded FlipperKit to 0.32.2 to ensure compatibility with latest
react-native-flipperTest Plan
Tested by upgrading the ReactNativeFlipperExample (https://github.com/facebook/flipper/tree/master/react-native/ReactNativeFlipperExample) to RN 0.62.0-rc.3 and verified the example plugin works. (In D20221558)