Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix semi-transparent backgrounds on Text components #23872

Closed
wants to merge 13 commits into from
Closed

[iOS] Fix semi-transparent backgrounds on Text components #23872

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
92bb41e
Don’t draw background for glyphs
ericlewis Mar 12, 2019
7a49b5a
Add test
ericlewis Mar 12, 2019
052718a
update snapshot
ericlewis Mar 12, 2019
410233f
Don’t draw outer background on RCTTextView
ericlewis Mar 13, 2019
997c19b
Update test
ericlewis Mar 13, 2019
800a03b
prune background color attributes when they match
ericlewis Mar 13, 2019
7a986b0
update snapshot
ericlewis Mar 13, 2019
0986a95
Simplify.
ericlewis Mar 13, 2019
dac4cc3
revert movements
ericlewis Mar 13, 2019
da0288b
Add comments, improve style.
ericlewis Mar 13, 2019
f187c66
Update TextExample.ios.js
shergin Mar 13, 2019
9d01035
Update RCTTextShadowView.m
shergin Mar 13, 2019
c4b07cc
update snapshot
ericlewis Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Libraries/Text/Text/RCTTextShadowView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge
return self;
}

-(void)didSetProps:(NSArray<NSString*>*)changedProps {
[super didSetProps:changedProps];
self.textAttributes.backgroundColor = nil;
}

- (BOOL)isYogaLeafNode
{
return YES;
Expand Down
Binary file modified ...ests/ReferenceImages/RNTester-js-RNTesterApp.ios/testTextExample_1-iOS12@2x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions RNTester/js/TextExample.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,17 @@ exports.examples = [
return <Text>{'test🙃'.substring(0, 5)}</Text>;
},
},
{
title: 'Transparent Background Color',
render: function() {
return (
<Text style={{backgroundColor: '#00000020', padding: 10}}>
Text in a gray box!
<Text style={{backgroundColor: 'red'}}> another text in red box</Text>
</Text>
);
},
},
{
title: 'Text metrics',
render: function() {
Expand Down