Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactSlider extends AppCompatSeekBar #23304

Closed
wants to merge 4 commits into from
Closed

ReactSlider extends AppCompatSeekBar #23304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0b2dcb
ReactSlider extends appcompat widget
dulmandakh Feb 6, 2019
18fb9c4
remove appcompat from tests
dulmandakh Feb 6, 2019
9f90543
Merge branch 'master' into reactslider-appcompat
dulmandakh Feb 6, 2019
f308383
fix dex
dulmandakh Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ReactAndroid/src/main/java/com/facebook/react/views/slider/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@ load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "r
rn_android_library(
name = "slider",
srcs = glob(["*.java"]),
provided_deps = [
react_native_dep("third-party/android/support/v7/appcompat-orig:appcompat"),
],
visibility = [
"PUBLIC",
],
deps = [
YOGA_TARGET,
react_native_dep("third-party/android/support/v7/appcompat-orig:appcompat"),
react_native_dep("third-party/android/support/v4:lib-support-v4"),
react_native_dep("third-party/java/jsr-305:jsr-305"),
react_native_target("java/com/facebook/react/bridge:bridge"),
react_native_target("java/com/facebook/react/common:common"),
Expand Down
4 changes: 2 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSlider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

import android.content.Context;
import android.os.Build;
import android.support.v7.widget.AppCompatSeekBar;
import android.util.AttributeSet;
import android.widget.SeekBar;
import javax.annotation.Nullable;

/**
Expand All @@ -20,7 +20,7 @@
*
* <p>Note that the slider is _not_ a controlled component (setValue isn't called during dragging).
*/
public class ReactSlider extends SeekBar {
public class ReactSlider extends AppCompatSeekBar {

/**
* If step is 0 (unset) we default to this total number of steps. Don't use 100 which leads to
Expand Down
1 change: 0 additions & 1 deletion ReactAndroid/src/main/third-party/android/support/v7/appcompat-orig/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ rn_android_library(
],
exported_deps = [
":classes-for-react-native",
react_native_dep("third-party/android/support-annotations:android-support-annotations"),
],
)

Expand Down