ReactActivity extends AppCompatActivity

[dulmandakh]

Summary

Google recommends to extend AppCompatActivity. and This PR changes ReactActivity to extend AppCompatActivity

Changelog

[Android] [Changed] - ReactActivity extends AppCompatActivity

Test Plan

CI is green and everything should work as usual.

[pull-bot]

	Warnings
⚠️	📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS

[dulmandakh]

@mdvacca I just realized that I had learned something about BUCK setup while working on landing Android Support Library 28.0.0. Please import it and see if it works. Thank you very much.

[facebook-github-bot]

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[dulmandakh]

@mdvacca is it work?

[mdvacca]

There is an internal build error because of lack of dependency but buck works fine, I will update that dependency and then land this

[react-native-bot]

@dulmandakh merged commit 3b9604f into facebook:master.

[mdvacca]

This PR produced runtime crashes with errors:
You need to use a Theme.AppCompat theme (or descendant) with this activity.

The fix is to use a Theme from AppCompat in the AndroidManifest.xml file:
e.g.:
`
Replace the theme from:
android:theme="@android:style/Theme.NoTitleBar"

to:
android:theme="@style/Theme.AppCompat.Light.NoActionBar"
`

We should flag this PR as a backward in-compatible change for next version release.
CC @cpojer, @hramos

[dulmandakh]

@mdvacca I couldn't find non AppCompat theme reference in RN repo. But I agree that we should add notes about it.