Fix artifacting on RN-drawn borders with asymmetric radii #21208
Conversation
|
Ah, it looks like this PR addresses the broadly-felt issue in #11897. There's another PR from @mattijsf (#19451) that also attempts to fix this. @mattijsf, you mention that there's still some bleeding happening, but not in the final result. Could you try my patch and see if it completely resolves the issue? I'd be happy to try any other test cases you've used, too. |
|
Thanks for the PR! Please ping me once you've resolved this with @mattijsf. |
|
Hi @hramos — I haven't heard anything from @mattijsf on this or the other PR. Given the age of his original PR, I think he may have moved on. My suggestion would be to evaluate and merge my fix on its merits, and if the chorus of users in Issue #11897 continue to experience problems after merging my fix, we can revive the other PR. |
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jamesreggio merged commit 9e65223 into |
Summary: This PR fixes an obscure rendering bug on iOS for borders with asymmetric radii. It appears to be a problem with the custom drawing that React Native performs when it cannot use native UIKit/CoreAnimation border drawing. Pull Request resolved: #21208 Differential Revision: D10130120 Pulled By: hramos fbshipit-source-id: d9fbc5c622c060db15658d038a068216b47bb26d
…1208) Summary: This PR fixes an obscure rendering bug on iOS for borders with asymmetric radii. It appears to be a problem with the custom drawing that React Native performs when it cannot use native UIKit/CoreAnimation border drawing. Pull Request resolved: facebook#21208 Differential Revision: D10130120 Pulled By: hramos fbshipit-source-id: d9fbc5c622c060db15658d038a068216b47bb26d
This PR fixes an obscure rendering bug on iOS for borders with asymmetric radii. It appears to be a problem with the custom drawing that React Native performs when it cannot use native UIKit/CoreAnimation border drawing.
Test Plan:
We've been using this patch in our production app without issue since July 2018. I've seen this issue on the latest version of iOS 10, as well as iOS 11.2 (though it seems to not be an issue on iOS 11.4 any longer).
I've included before/after screenshots below, which also show the CSS needed to cause the artifacting.
Release Notes:
[IOS] [BUGFIX] [BorderDrawing] - Fixed visual artifacts on borders with asymmetric radii