Fixed status code when run-android fails #21012
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
The failing tests seem unrelated to me. |
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Fixes facebook#21011 Pull Request resolved: facebook#21012 Differential Revision: D9721471 Pulled By: hramos fbshipit-source-id: 91f24c6009bd4f5399cffad960feed7213516145
Summary: Fixes #21011 Pull Request resolved: facebook/react-native#21012 Differential Revision: D9721471 Pulled By: hramos fbshipit-source-id: 91f24c6009bd4f5399cffad960feed7213516145
Summary: Fixes facebook#21011 Pull Request resolved: facebook#21012 Differential Revision: D9721471 Pulled By: hramos fbshipit-source-id: 91f24c6009bd4f5399cffad960feed7213516145
Fixes #21011
Test Plan:
See the steps on how to reproduce on the original issue, after this PR the process no longer exits with 0, but exit code 1.
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CLI] [BUGFIX] [local-cli/runAndroid/runAndroid.js] - Fixed status code when
run-androidfails.